Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Brave Wallet -> Crypto Wallets in extension settings #3587

Merged
merged 1 commit into from
Oct 6, 2019

Conversation

bbondy
Copy link
Member

@bbondy bbondy commented Oct 2, 2019

Fix brave/brave-browser#6172

Submitter Checklist:

Test Plan:

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

After-merge Checklist:

  • The associated issue milestone is set to the smallest version that the
    changes has landed on.
  • All relevant documentation has been updated.

@bbondy bbondy added this to the 0.72.x - Nightly milestone Oct 2, 2019
@bbondy bbondy requested a review from emerick October 2, 2019 22:05
@bbondy bbondy self-assigned this Oct 2, 2019
@bbondy bbondy force-pushed the wallet-extension-name branch from 94589bc to 5f5a324 Compare October 2, 2019 22:17
Copy link
Contributor

@emerick emerick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bbondy bbondy merged commit de305a8 into master Oct 6, 2019
@bsclifton bsclifton deleted the wallet-extension-name branch October 8, 2019 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Crypto Wallets setting: text & functionality
2 participants